Skip to content

Conversation

@omagoduck
Copy link

@omagoduck omagoduck commented Jul 5, 2025

Related GitHub Issue

Closes: #5336

This PR is split from the following, as requested by collaborators.

Partially Closes: #5338

Description

🚀 New Features

  1. General Settings Section
    • Added a preference toggle in Settings to view all recent tasks from any workspace (streamlining single-workspace limitation in main UI).

Test Procedure

I just tested on the debug server of VS Code and also by installing the actual bundled version of this.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Before:
image

After:
image

Additional Notes

I am a new developer and am hassling keeping pace with your rapidly updating codebase. Please either do the merge if acceptable, or just inform me if you cannot.

Get in Touch

Discord username: al_bayazid (I am not always active there. Better comment below!)

@daniel-lxs


Important

Introduces a setting to toggle viewing tasks from all workspaces, updating UI components, settings schema, and localization files.

  • New Feature:
    • Adds showAllWorkspacesTasks boolean to globalSettingsSchema in global-settings.ts.
    • Implements toggle for viewing tasks from all workspaces in ClineProvider.ts and HistoryView.tsx.
    • Integrates feature into settings UI via GeneralSettings.tsx and SettingsView.tsx.
  • Tests:
    • Updates ClineProvider.spec.ts and useTaskSearch.spec.tsx to test new feature.
  • Localization:
    • Adds translations for new setting in multiple language files, including settings.json for various locales.

This description was created by Ellipsis for f1111bb. You can customize this summary. It will automatically update as commits are pushed.

@omagoduck omagoduck requested review from cte, jr and mrubens as code owners July 5, 2025 06:28
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jul 5, 2025
},
"prompts": {
"description": "設定用於快速操作的支援提示詞,如增強提示詞、解釋程式碼和修復問題。這些提示詞幫助 Roo 為常見開發工作提供更好的支援"
"description": "設定用於快速操作的支援提示詞,如增強提示詞、解釋程式碼和修復問題。這些提示詞幫助 Roo 提供支援更好的支援,以協助處理常見的開發任務"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typographical error: The phrase “支援更好的支援” is redundant. It might be intended as “提供更好的支援”. Please revise for clarity.

Suggested change
"description": "設定用於快速操作的支援提示詞,如增強提示詞、解釋程式碼和修復問題。這些提示詞幫助 Roo 提供支援更好的支援,以協助處理常見的開發任務。"
"description": "設定用於快速操作的支援提示詞,如增強提示詞、解釋程式碼和修復問題。這些提示詞幫助 Roo 提供更好的支援,以協助處理常見的開發任務。"

Copy link
Author

@omagoduck omagoduck Jul 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not responsible for the error. I didn't made it.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 5, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jul 5, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jul 5, 2025
@daniel-lxs
Copy link
Member

@omagoduck It seems like your recent commit is causing some tests to fail, can you take a look?

@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Draft / In Progress] in Roo Code Roadmap Jul 9, 2025
@daniel-lxs daniel-lxs marked this pull request as draft July 9, 2025 18:22
@omagoduck
Copy link
Author

@omagoduck It seems like your recent commit is causing some tests to fail, can you take a look?

Okay I am going to check!

@omagoduck omagoduck marked this pull request as ready for review July 10, 2025 06:50
},
"prompts": {
"description": "設定用於快速操作的支援提示詞,如增強提示詞、解釋程式碼和修復問題。這些提示詞幫助 Roo 為常見開發工作提供更好的支援"
"description": "設定用於快速操作的支援提示詞,如增強提示詞、解釋程式碼和修復問題。這些提示詞幫助 Roo 提供支援更好的支援,以協助處理常見的開發任務"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typographical error: The description under 'prompts' contains a repeated '支援' phrase ('提供支援更好的支援'). Please revise to something like '這些提示詞幫助 Roo 提供更好的支援,以協助處理常見的開發任務。' to improve clarity.

Suggested change
"description": "設定用於快速操作的支援提示詞,如增強提示詞、解釋程式碼和修復問題。這些提示詞幫助 Roo 提供支援更好的支援,以協助處理常見的開發任務。"
"description": "設定用於快速操作的支援提示詞,如增強提示詞、解釋程式碼和修復問題。這些提示詞幫助 Roo 提供更好的支援,以協助處理常見的開發任務。"

@omagoduck
Copy link
Author

@daniel-lxs I have merged upto upstream (for now at least)

@omagoduck
Copy link
Author

omagoduck commented Jul 10, 2025

@omagoduck It seems like your recent commit is causing some tests to fail, can you take a look?

For how many days has it been hanging?

@omagoduck
Copy link
Author

How much time do you take to check and merge a PR? Please clear me!

@daniel-lxs daniel-lxs moved this from PR [Draft / In Progress] to PR [Needs Prelim Review] in Roo Code Roadmap Jul 11, 2025
@daniel-lxs
Copy link
Member

Hey @omagoduck, you can already view all tasks using these:

image

Creating a new section in the settings for this sole setting seems unnecessary.

I'll close this PR for but please let me know if you have any questions about this.

@daniel-lxs daniel-lxs closed this Jul 14, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Prelim Review] to Done in Roo Code Roadmap Jul 14, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request PR - Needs Preliminary Review size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Enable me to see all workspaces from recent tasks UI based on my preference.

3 participants